Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use shared: true and format: 'es' #17

Closed
Rich-Harris opened this issue Mar 19, 2017 · 1 comment
Closed

Always use shared: true and format: 'es' #17

Rich-Harris opened this issue Mar 19, 2017 · 1 comment

Comments

@Rich-Harris
Copy link
Member

There's no reason for shared: true to be configurable — there's no advantage in a webpack context to not sharing helpers.

I think the format should always be es — webpack can handle modules natively, right? (Not a webpack user, I could be wrong about this.) There's no reason for it to be anything else, is there?

More generally, rather than passing down each option in turn, it would probably make sense to pass through all the options, overriding the ones we need to.

@TheLarkInn
Copy link

Yup, so returned source can be esm export

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants