Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests for slot binding #602

Merged
merged 1 commit into from
Dec 1, 2024
Merged

chore: add tests for slot binding #602

merged 1 commit into from
Dec 1, 2024

Conversation

baseballyama
Copy link
Member

close: #564

I confirmed slot binding is works as expected in Svelte5 but not in Svelte4.
I just added tests for this.

Copy link

changeset-bot bot commented Dec 1, 2024

⚠️ No Changeset found

Latest commit: a69ee52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12101386373

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.862%

Totals Coverage Status
Change from base Build 12100948993: 0.0%
Covered Lines: 2998
Relevant Lines: 3217

💛 - Coveralls

@ota-meshi ota-meshi merged commit 2c7c1e6 into main Dec 1, 2024
10 checks passed
@ota-meshi ota-meshi deleted the fix/564 branch December 1, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If component is generic, events and slot bindings are treated as any in ESLint
3 participants