fix: infinite loop in attr.ts (#409)

* fix: infinite loop * Create weak-lizards-listen.md * fix
sveltejs · Oct 3, 2023 · b63c305 · b63c305
1 parent f92689e
commit b63c305
Show file tree

Hide file tree

Showing 5 changed files with 2,684 additions and 2 deletions.
diff --git a/.changeset/weak-lizards-listen.md b/.changeset/weak-lizards-listen.md
@@ -0,0 +1,5 @@
+---
+"svelte-eslint-parser": patch
+---
+
+fix: infinite loop in attr.ts
diff --git a/src/parser/converts/attr.ts b/src/parser/converts/attr.ts
@@ -18,6 +18,8 @@ import type {
   SvelteElement,
   SvelteScriptElement,
   SvelteStyleElement,
+  SvelteElseBlock,
+  SvelteAwaitBlock,
 } from "../../ast";
 import type ESTree from "estree";
 import type { Context } from "../../context";
@@ -678,9 +680,13 @@ function buildLetDirectiveType(
 
   /** Find parent component element */
   function findParentComponent(node: SvelteElement) {
-    let parent: SvelteElement["parent"] | null = node.parent;
+    let parent:
+      | SvelteElement["parent"]
+      | SvelteElseBlock
+      | SvelteAwaitBlock
+      | null = node.parent;
     while (parent && parent.type !== "SvelteElement") {
-      parent = node.parent;
+      parent = parent.parent;
     }
     if (!parent || parent.kind !== "component") {
       return null;

diff --git a/tests/fixtures/parser/ast/let-directive04-input.svelte b/tests/fixtures/parser/ast/let-directive04-input.svelte
@@ -0,0 +1,12 @@
+<!-- Copied from https://github.com/sveltejs/svelte-eslint-parser/issues/408-->
+<script lang="ts">
+export let collapsed = false;
+</script>
+
+<div>
+    {#if !collapsed}
+        <svelte:self collapsed let:something>
+            <slot {something} />
+        </svelte:self>
+    {/if}
+</div>