chore: remove eslint-plugin-svelte3 from demo site

sveltejs · Sep 22, 2023 · 4f66e48 · 4f66e48
1 parent b38f1b7
commit 4f66e48
Show file tree

Hide file tree

Showing 10 changed files with 3 additions and 86 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -10,7 +10,6 @@
 /explorer-v2/build
 /explorer-v2/build-system/shim/svelte-eslint-parser.*
 /explorer-v2/build-system/shim/eslint-scope.*
-/explorer-v2/build-system/shim/eslint-plugin-svelte3.*
 /explorer-v2/build-system/shim/eslint.*
 /explorer-v2/build-system/shim/svelte/*
 !/.vscode

diff --git a/explorer-v2/.gitignore b/explorer-v2/.gitignore
@@ -5,6 +5,5 @@ node_modules
 /functions
 /build-system/shim/svelte-eslint-parser.*
 /build-system/shim/eslint-scope.*
-/build-system/shim/eslint-plugin-svelte3.*
 /build-system/shim/eslint.*
 /build-system/shim/svelte/*
diff --git a/explorer-v2/.prettierignore b/explorer-v2/.prettierignore
@@ -4,5 +4,4 @@ build/**
 node_modules/**
 /build-system/shim/svelte-eslint-parser.*
 /build-system/shim/eslint-scope.*
-/build-system/shim/eslint-plugin-svelte3.*
 /build-system/shim/eslint.*
diff --git a/explorer-v2/build-system/pre-build/eslint-plugin-svelte3.js b/explorer-v2/build-system/pre-build/eslint-plugin-svelte3.js
diff --git a/explorer-v2/build-system/pre-build/webpack.config.js b/explorer-v2/build-system/pre-build/webpack.config.js
@@ -85,56 +85,6 @@ export default [
 			})
 		]
 	},
-	{
-		...base,
-		entry: {
-			'eslint-plugin-svelte3': resolve('./eslint-plugin-svelte3.js')
-		},
-		module: {
-			rules: [
-				{
-					test: /node_modules\/eslint-plugin-svelte3\/index\.js$/u,
-					loader: 'string-replace-loader',
-					options: {
-						search: 'Object\\.keys\\(__require\\.cache\\)',
-						replace: (original) => `[] /* ${original} */`,
-						flags: ''
-					}
-				},
-				{
-					test: /node_modules\/eslint-plugin-svelte3\/index\.js$/u,
-					loader: 'string-replace-loader',
-					options: {
-						search: 'require\\(linter_path\\)',
-						replace: (original) => `require('eslint'); // ${original}`,
-						flags: ''
-					}
-				},
-				{
-					test: /node_modules\/eslint-plugin-svelte3\/index\.js$/u,
-					loader: 'string-replace-loader',
-					options: {
-						search: "throw new Error\\('Could not find ESLint Linter in require cache'\\);",
-						replace: (original) => ` // ${original}`,
-						flags: ''
-					}
-				}
-			]
-		},
-		externals: {
-			'svelte/compiler': '$$inject_svelte_compiler$$',
-			eslint: '$$inject_eslint$$'
-		},
-		plugins: [
-			new WrapperPlugin({
-				test: /eslint-plugin-svelte3\.js/,
-				header: `
-				import * as $$inject_svelte_compiler$$ from 'svelte/compiler';
-				import * as $$inject_eslint$$ from 'eslint';
-				`
-			})
-		]
-	},
 	{
 		...base,
 		entry: {

diff --git a/explorer-v2/package.json b/explorer-v2/package.json
@@ -15,7 +15,6 @@
 		"@fontsource/fira-mono": "^5.0.0",
 		"@typescript-eslint/parser": "^6.0.0",
 		"eslint": "^8.0.0",
-		"eslint-plugin-svelte3": "^4.0.0",
 		"eslint-scope": "^7.0.0",
 		"esquery": "^1.5.0",
 		"pako": "^2.0.3",

diff --git a/explorer-v2/src/lib/ESLintPlayground.svelte b/explorer-v2/src/lib/ESLintPlayground.svelte
@@ -30,9 +30,7 @@
 	let code = state.code || DEFAULT_CODE;
 	let rules = state.rules || Object.assign({}, DEFAULT_RULES_CONFIG);
 	let messages = [];
-	let useEslintPluginSvelte3 = Boolean(state.useEslintPluginSvelte3);
 	let time = '';
-	let options = {};
 
 	$: hasLangTs = /lang\s*=\s*(?:"ts"|ts|'ts'|"typescript"|typescript|'typescript')/u.test(code);
 	let tsParser = undefined;
@@ -51,25 +49,14 @@
 			});
 		}
 	}
-	$: {
-		options = useEslintPluginSvelte3 ? getEslintPluginSvelte3Options() : {};
-	}
-	async function getEslintPluginSvelte3Options() {
-		const pluginSvelte3 = await import('eslint-plugin-svelte3');
-		return {
-			preprocess: pluginSvelte3.processors.svelte3.preprocess,
-			postprocess: pluginSvelte3.processors.svelte3.postprocess
-		};
-	}
 
 	// eslint-disable-next-line no-use-before-define -- false positive
 	$: serializedString = (() => {
 		const serializeCode = DEFAULT_CODE === code ? undefined : code;
 		const serializeRules = equalsRules(DEFAULT_RULES_CONFIG, rules) ? undefined : rules;
 		return serializeState({
 			code: serializeCode,
-			rules: serializeRules,
-			useEslintPluginSvelte3: useEslintPluginSvelte3 ? true : undefined
+			rules: serializeRules
 		});
 	})();
 	$: {
@@ -98,7 +85,6 @@
 			const state = deserializeState(newSerializedString);
 			code = state.code || DEFAULT_CODE;
 			rules = state.rules || Object.assign({}, DEFAULT_RULES_CONFIG);
-			useEslintPluginSvelte3 = Boolean(state.useEslintPluginSvelte3);
 		}
 	}
 
@@ -121,14 +107,6 @@
 
 <div class="playground-root">
 	<div class="playground-tools">
-		<label>
-			<input bind:checked={useEslintPluginSvelte3} type="checkbox" />
-			See result of
-			<a href="https://github.com/sveltejs/eslint-plugin-svelte3">eslint-plugin-svelte3</a>.
-		</label>
-		{#if useEslintPluginSvelte3}
-			<span style="color: red">svelte-eslint-parser is not used.</span>
-		{/if}
 		<span style="margin-left: 16px">{time}</span>
 	</div>
 	<div class="playground-content">
@@ -138,7 +116,7 @@
 				{linter}
 				bind:code
 				config={{
-					parser: useEslintPluginSvelte3 ? undefined : 'svelte-eslint-parser',
+					parser: 'svelte-eslint-parser',
 					parserOptions: {
 						ecmaVersion: 2020,
 						sourceType: 'module',
@@ -150,7 +128,6 @@
 						es2021: true
 					}
 				}}
-				{options}
 				class="eslint-playground"
 				on:result={onLintedResult}
 			/>

diff --git a/explorer-v2/src/lib/scripts/state/deserialize.js b/explorer-v2/src/lib/scripts/state/deserialize.js
@@ -26,9 +26,6 @@ export function deserializeState(serializedString) {
 			if (typeof json.code === 'string') {
 				state.code = json.code;
 			}
-			if (json.useEslintPluginSvelte3 === true) {
-				state.useEslintPluginSvelte3 = true;
-			}
 
 			if (typeof json.rules === 'object' && json.rules != null) {
 				state.rules = {};

diff --git a/explorer-v2/src/lib/scripts/state/serialize.js b/explorer-v2/src/lib/scripts/state/serialize.js
@@ -22,8 +22,7 @@ function getEnabledRules(allRules) {
 export function serializeState(state) {
 	const saveData = {
 		code: state.code,
-		rules: state.rules ? getEnabledRules(state.rules) : undefined,
-		useEslintPluginSvelte3: state.useEslintPluginSvelte3
+		rules: state.rules ? getEnabledRules(state.rules) : undefined
 	};
 	const jsonString = JSON.stringify(saveData);
 	// eslint-disable-next-line n/no-unsupported-features/node-builtins -- ignore

diff --git a/explorer-v2/vite.config.js b/explorer-v2/vite.config.js
@@ -18,7 +18,6 @@ const config = {
 			tslib: resolve('./node_modules/tslib/tslib.es6.js'),
 			eslint: resolve('./build-system/shim/eslint.js'),
 			'svelte-eslint-parser': resolve('./build-system/shim/svelte-eslint-parser.js'),
-			'eslint-plugin-svelte3': resolve('./build-system/shim/eslint-plugin-svelte3.js'),
 			'svelte/compiler': resolve('./build-system/shim/svelte/compiler.js')
 		}
 	}