-
Notifications
You must be signed in to change notification settings - Fork 214
Pwa audit/add meta description to routes #158
Pwa audit/add meta description to routes #158
Conversation
Excuse the name of the branch, this is not a pws specific change. As part of this PR I can also change a few other items that the audit picked up. Thoughts? |
that's the issue that goes along with this sveltejs/svelte#1607 |
something odd is going on, based of the template, when I apply this patch, then After that, clicking between the items inside Nav doesn't show the route contents anymore e.g. try clicking 'about' or 'blog' and back to 'home'. Nothing is rendered. I tested on current Chrome within incognito window just to make sure no extension etc. is going to trick something but didn't change the result. Same in normal window of course. |
Adding meta to |
yup, it does, so it's verified here's the console error log
going down the rabbit hole it seems it doesn't have a parent node because it explodes at
|
See sveltejs/svelte#3187 (comment) - I believe this is a bug that needs to be fixed in Svelte, not worked around in Sapper. |
It looks like it was fixed in Svelte 3.6.7 |
I'm going to close this since we're now on a newer version of Svelte |
Summary
Add
meta
descriptions to all routes in the generated sample template based off Lighthouse Audit recommendations.Audit Trail
After
Before