(fix) adjust snipping spans

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## 2.5.0 (Unreleased)
 
 * (feat) Support `bracketSameLine` option and deprecate `svelteBracketNewLine` ([#251](https://github.com/sveltejs/prettier-plugin-svelte/pull/251))
+* (fix) Prevent script/style contents from being erased in certain cases ([#255](https://github.com/sveltejs/prettier-plugin-svelte/issues/255))
 
 ## 2.4.0
 

src/lib/snipTagContent.ts

@@ -16,7 +16,9 @@ export function snipScriptAndStyleTagContent(source: string): string {
         const indexes: [number, number][] = [];
         let match = null;
         while ((match = regex.exec(source)) != null) {
-            indexes.push([match.index, regex.lastIndex]);
+            if (!source.substr(match.index, 10).startsWith('<!--')) {
+                indexes.push([match.index, regex.lastIndex]);
+            }
         }
         return indexes;
     }
@@ -27,18 +29,32 @@ export function snipScriptAndStyleTagContent(source: string): string {
         placeholder: string,
         otherSpans: [number, number][],
     ) {
+        // Replace valid matches
         const regex = getRegexp(tagName);
-        return _source.replace(regex, (match, attributes, content, index) => {
+        const newSource = _source.replace(regex, (match, attributes, content, index) => {
             if (match.startsWith('<!--') || withinOtherSpan(index)) {
                 return match;
             }
             const encodedContent = Buffer.from(content).toString('base64');
             return `<${tagName}${attributes} ${snippedTagContentAttribute}="${encodedContent}">${placeholder}</${tagName}>`;
         });
 
+        // Adjust the spans because the source now has a different content length
+        adjustSpans(scriptMatchSpans);
+        adjustSpans(styleMatchSpans);
+
+        return newSource;
+
         function withinOtherSpan(idx: number) {
             return otherSpans.some((otherSpan) => idx > otherSpan[0] && idx < otherSpan[1]);
         }
+        function adjustSpans(spans: [number, number][]) {
+            const lengthDiff = _source.length - newSource.length;
+            spans.forEach((span) => {
+                span[0] -= lengthDiff;
+                span[1] -= lengthDiff;
+            });
+        }
     }
 
     function getRegexp(tagName: string) {

test/printer/samples/style-scripts-snipping-spans.html

@@ -0,0 +1,13 @@
+<script lang="ts" context="module">
+    // we need a certain length here
+</script>
+
+<script lang="ts">
+    // we need a certain length here
+</script>
+
+<style type="scss">
+    /* we need a certain length here */
+</style>
+
+<!-- this test checks that the matching spans are adjusted after replacing the code, as otherwise it would mess up the snipping -->

test/printer/samples/style-scripts-snipping-spans.options.json

@@ -0,0 +1,3 @@
+{
+    "svelteSortOrder": "options-scripts-styles-markup"
+}