Do not add whitespace between text and HTML nodes (fixes #24) #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mma in "<b>Milk</b>, <b>Bread</b>")
ehrencrona
changed the title
…ce inside inline elements
|
Also reported in sveltejs/language-tools#323 |
This was referenced Aug 23, 2020
Merged
rudolfs
added a commit
to radicle-dev/radicle-upstream
that referenced
this pull request
Sep 3, 2020
rudolfs
added a commit
to radicle-dev/radicle-upstream
that referenced
this pull request
Sep 4, 2020
* Adjust existing onboarding visuals * Split out component * Add "enter passphrase" screen * Fix clearing session ends up on blank screen * Rename identity creation flow to onboarding * Move identity creation logic to top-level screen * Improve spec readability * Replace cancel buttons with one back button * Update success screen styling * Add password validations * Use enter key to progress through onboarding * Extract common function * Add keyboard navigation spec * Update success page * Add animations * Debounce actions * Convert px to rem * Disable global hotkeys during onboarding * Use validations properly in EnterName screen * Fix prettier messing up whitespace in HTML sveltejs/prettier-plugin-svelte#116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add a line break before the comma in
<b>Milk</b>, <b>Bread</b>, inside the quotation marks in"<i>Hola</i>" or "<i>Hello</i>"or inside the links inclick <a href=''>here</a> or <a href=''>there</a>This was merged as part of #120. Closing this.
Fixes #103 Fixes #24
It has also been reported as sveltejs/language-tools#64
Looking at #58, it does not fix the discrepancies between the standard HTML formatting and svelte (it will line break between
aandhref), but it does preserve whitespace in an appropriate way.