Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support modifiers on style directives #330

Closed
mike-moreau opened this issue Dec 8, 2022 · 0 comments · Fixed by #331
Closed

Support modifiers on style directives #330

mike-moreau opened this issue Dec 8, 2022 · 0 comments · Fixed by #331
Labels
enhancement New feature or request

Comments

@mike-moreau
Copy link

Describe the bug

Hey there,

I'm using Svelte for VS Code to format files on save.

When adding an |important modifier to a style directive in a .svelte file, the modifier gets removed when the file is formatted.

I tried disabling formatting by adding *.svelte to my Prettier ignore file, and the modifier was preserved as expected.

Reproduction

Add a style directive with |important and save the file. Watch it disappear...spooky...

Expected behaviour

Modifier to persist after formatting.

System Info

  • OS: MacOS
  • IDE: VSCode

Which package is the issue about?

Svelte for VS Code extension

Additional Information, eg. Screenshots

No response
@mike-moreau mike-moreau added the bug Something isn't working label Dec 8, 2022
@dummdidumm dummdidumm transferred this issue from sveltejs/language-tools Dec 9, 2022
@dummdidumm dummdidumm added enhancement New feature or request and removed bug Something isn't working labels Dec 9, 2022
@dummdidumm dummdidumm changed the title The |important modifier on style directives gets removed when using Svelte for VS Code Support modifiers on style directives Dec 9, 2022
dummdidumm added a commit to dummdidumm/prettier-plugin-svelte that referenced this issue Dec 9, 2022
@dummdidumm
(feat) support style modifiers
6dd5eac 
closes sveltejs#330
@dummdidumm dummdidumm mentioned this issue Dec 9, 2022
Merged
dummdidumm added a commit that referenced this issue Dec 9, 2022
@dummdidumm
(feat) support style modifiers (#331)
f3685aa 
closes #330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(feat) support style modifiers dummdidumm/prettier-plugin-svelte
2 participants
@dummdidumm @mike-moreau