Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style attribute hover/completion #924

Merged
merged 8 commits into from
Apr 2, 2021
Merged

Style attribute hover/completion #924

merged 8 commits into from
Apr 2, 2021

Conversation

jasonlyu123
Copy link
Member

#381
圖片

Only added hover and completion as it's the easiest and doesn't require a full document scan.

dummdidumm
dummdidumm reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! I like the idea of an embedded on-the-fly document for this purpose to reuse all the existing functionality 👍 Added two small notes.

packages/language-server/src/lib/documents/parseHtml.ts Outdated Show resolved Hide resolved
packages/language-server/src/plugins/css/CSSPlugin.ts Show resolved Hide resolved
@dummdidumm dummdidumm merged commit 22a32ef into sveltejs:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonlyu123 @dummdidumm