-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: svelte-check v4 #2453
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d01b678
breaking: make TypeScript a peer dependency
dummdidumm 6fda024
breaking: require node 18 or later
dummdidumm 03482d0
breaking: require Svelte 4 or later
dummdidumm 5aca29f
Merge branch 'master' into svelte-check-major
dummdidumm ea8c0bd
chore: switch from fast-glob to fdir (#2433)
benmccann 6471fae
Merge branch 'master' into svelte-check-major
dummdidumm 7a1f80a
chore: remove svelte-preprocess dependency from svelte-check
dummdidumm f580633
breaking: throw when `--ignore` is used without `--no-tsconfig`
dummdidumm 6a7f19d
Merge branch 'master' into svelte-check-major
dummdidumm 6fc7299
Update packages/language-server/src/lib/documents/configLoader.ts
dummdidumm 0dc740f
Update packages/svelte-check/src/index.ts
dummdidumm 471112e
4.0
dummdidumm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we support some versions of Typescript 4? It might be nice for users who haven't been able to upgrade yet if it's not too hard for us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reminding me to bump the Svelte peer dependency to v4 😄 And since v4 has an implicit dependency requirement on TS >=5 we should, too. Better to nudge users towards upgrading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think users will have plenty of reason to upgrade on their own since Svelte 5 is so much better. But it'd probably be appreciated if we let them do it in their own time instead of forcing them. It can make things easier to have wider support as you have more flexibility around what order to upgrade various libraries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't forcing people to jump to Svelte 5, only Svelte 4 - which you need to do before upgrading to 5 anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I know. I was just saying people would want to upgrade to Svelte 4 in order to get to 5 so we don't need to push them too hard