-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TypeScript 5.4 support for svelte-check #2313
Conversation
Seems like auto-import is broken in js/non-ts-svelte files importing |
Is this reproducible without Svelte? i.e. import a |
Yeah. it also happens in js files. Also found that the problem with |
Let's wait until VSCode releases with TypeScript 5.4 to see if enough people complain about it and see if the fix can made into a 5.4 patch release. If not, we can probably either
|
The bug was put into the backlog, it doesn't look like it has any priority. We may have to dig into the code base ourselves and make a TS pull request. Would you be willing to try that? |
Follow up to #2313. The auto-import problem is fixed in 5.4.5.
It looks like the TypeScript version in the svelte-check package still needs to be updated. I'm getting errors when running svelte-check that don't appear in VS Code, where I'm running the latest TypeScript. |
Auto import seems to be broken. Need to check what the problem is. We also need to check if the Preserved Narrowing in Closures Following Last Assignments changes the narrowing in any unexpected ways (#2316).
Auto Import in non-ts svelte file has some regression in 5.4. So this only adds the support for svelte-check. Editor support waiting on if the upstream fix is merged. So 5.4 might be skipped.