(fix) resolve plugin config for prettier #1829
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1766 and sveltejs/kit#7582
Should resolve the problems mentioned in #1763 but not sure if we need to show a notification if
require.resolve
failed.The reason why we need to resolve the
plugins
config is mentioned here. I originally thought that plugins should be resolved with the config path. But I found that prettier-vscode resolves them with the document path.