Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix anchor missing attribute code action duplicate rel attribute #1812

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Fix anchor missing attribute code action duplicate rel attribute #1812

merged 3 commits into from
Jan 9, 2023

Conversation

cooolbros
Copy link
Contributor

Fixes #1811

svelte-anchor-missing-attribute-code-action-duplicate-rel-fix

@cooolbros
Copy link
Contributor Author

I've updated the code action to insert the noreferrer attribute after the existing noopener. It seems the check fail is unrelated

dummdidumm
dummdidumm approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit a240c90 into sveltejs:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add-noreferrer-quick-fix shouldn't add duplicated rel attribute
2 participants
@cooolbros @dummdidumm