(fix) fix event completion with createEventDispatcher or with multiple declarations of the same event #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
reviewed
Jul 3, 2021
| @@ -57,14 +57,17 @@ export class JsOrTsComponentInfoProvider implements ComponentInfoProvider { | |||
| return type | |||
| .getProperties() | |||
| .map((prop) => { | |||
| if (!prop.valueDeclaration) { | |||
| // currently there should only be one because svelte2tsx doesn't merge event dispatcher types | |||
| // And interface ($$Events) can't merge property type | |||
There was a problem hiding this comment.
Not sure how to interpret this sentence. In #938 merging multiple decent dispatcher definitions was done. Are completions working for these, too?
Not saying we need to fix that right away if not, since this is arguably an edge case
There was a problem hiding this comment.
I tested it. Even if there're multiple declarations the type would still be correct. I think I'll remove the comment and add another test for union type.
jasonlyu123
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic type parameter is not in the
valueDeclarationproperty of the typescript symbol.