Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[svelte-check] show which css selector is unused #434

Closed
TheComputerM opened this issue Aug 8, 2020 · 4 comments
Closed

[svelte-check] show which css selector is unused #434

TheComputerM opened this issue Aug 8, 2020 · 4 comments
Labels
feature request New feature or request Fixed Fixed in master branch. Pending production release.

Comments

@TheComputerM
Copy link

When showing the warning Warn: Unused CSS selector (svelte), if this could also show which selector is unused would be very useful, especially for components with large CSS content

@dummdidumm
Copy link
Member

dummdidumm commented Aug 8, 2020

svelte-check (human mode) already prints the surrounding characters at the position. What is the solution you'd like instead?
Problem is, we only get the position from the svelte compiler, which is a little off when using less/scss. To get this right the compiler would need to give us the name.

@TheComputerM
Copy link
Author

But when the style with src is used it highlights the style tag

@dummdidumm
Copy link
Member

Oh okay, have not thought of this situation. Well then we definitely need the name from the compiler.

@dummdidumm dummdidumm added the feature request New feature or request label Aug 9, 2020
dummdidumm pushed a commit to dummdidumm/language-tools that referenced this issue Sep 11, 2020
dummdidumm added a commit that referenced this issue Sep 11, 2020
@dummdidumm dummdidumm added the Fixed Fixed in master branch. Pending production release. label Sep 11, 2020
@dummdidumm
Copy link
Member

Fixed with Svelte 3.25.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

2 participants