(fix) strip doctype before jsx is generated (#213)

* fix(204): strip doctype before jsx is generated * fix(204): add tests to validate doctype if removed Fixes #204
sveltejs · Jun 20, 2020 · 3ef9d78 · 3ef9d78
1 parent 5437e5f
commit 3ef9d78
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/packages/svelte2tsx/src/htmlxtojsx.ts b/packages/svelte2tsx/src/htmlxtojsx.ts
@@ -20,6 +20,12 @@ const beforeStart = (start: number) => start - 1;
 
 type Walker = (node: Node, parent: Node, prop: string, index: number) => void;
 
+const stripDoctype = (str: MagicString) => {
+    const regex = /<!doctype(.+?)>(\n)?/i;
+    const result = regex.exec(str.original);
+    if (result) str.remove(result.index, result.index + result[0].length);
+};
+
 // eslint-disable-next-line max-len
 export function convertHtmlxToJsx(
     str: MagicString,
@@ -28,6 +34,7 @@ export function convertHtmlxToJsx(
     onLeave: Walker = null,
 ) {
     const htmlx = str.original;
+    stripDoctype(str);
     str.prepend('<>');
     str.append('</>');
     const handleRaw = (rawBlock: Node) => {

diff --git a/packages/svelte2tsx/test/htmlx2jsx/samples/doctype/expected.jsx b/packages/svelte2tsx/test/htmlx2jsx/samples/doctype/expected.jsx
@@ -0,0 +1,5 @@
+<><html lang="en">
+<body>
+    <h1>Svelte</h1>
+</body>
+</html></>
diff --git a/packages/svelte2tsx/test/htmlx2jsx/samples/doctype/input.svelte b/packages/svelte2tsx/test/htmlx2jsx/samples/doctype/input.svelte
@@ -0,0 +1,6 @@
+<!DOCTYPE html>
+<html lang="en">
+<body>
+    <h1>Svelte</h1>
+</body>
+</html>