-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New 'Hello World' page #934
Closed
Closed
Changes from 9 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5137adb
Adding new 'hello world' templates - both skeleton and default variat…
rafaelcamaram 6b4be20
Fixing typo related to 'hello world' message pointing index route path
rafaelcamaram 5a4277b
Adding changeset
rafaelcamaram 574cb02
Updating create-svelte lint command in order to consider template-ske…
rafaelcamaram c5df749
Removing unnecessary console.logs
rafaelcamaram ca0ccea
Moving Sun/Moon SVG code to asset SVG file
rafaelcamaram a0019e4
Moving Increase/Decrease Counter SVG codes to asset SVG files
rafaelcamaram a2722c4
Reverting changes related to Increase/Decrease Counter icons since it…
rafaelcamaram d692fdc
Improving some points related to add_css and add_typescript file methods
rafaelcamaram 68080f6
Removing skeleton template
rafaelcamaram 3e43b5e
Fixing PR comments made by benmccann
rafaelcamaram 5f5523c
Removing svelte-kit-demo in favor of new hello world page
rafaelcamaram 0c71f4f
Removing built-in support for CSS/LESS/SCSS modifications (it will be…
rafaelcamaram 815475d
Adding is_skeleton_template to create-svelte CLI
rafaelcamaram 30968db
Fixing merge conflicts with master
rafaelcamaram fb48e17
Fixing merge conflicts with master related to Counter.svelte
rafaelcamaram 6221e23
New Hello World page. Fixing add_typescript typos, removing unnecessa…
rafaelcamaram bad4fbc
Applying prettier/lint
rafaelcamaram b775c3c
Updating Hellow World eslint package json command in order to stop co…
rafaelcamaram d90c015
Applying suggestions made by dummdidumm regarding CSS classname patte…
rafaelcamaram 447f4f6
Merge branch 'master' of github.com:sveltejs/kit into camara/gh-90
rafaelcamaram 78b8ece
Updating CLI message related to addon possibilities
rafaelcamaram File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'create-svelte': patch | ||
--- | ||
|
||
Adding new 'hello world' templates - skeleton and default variants -. Applying it to the CLI as well |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,80 @@ | ||
:root { | ||
font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen, Ubuntu, Cantarell, | ||
'Open Sans', 'Helvetica Neue', sans-serif; | ||
font-family: Arial, -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen, Ubuntu, | ||
Cantarell, 'Open Sans', 'Helvetica Neue', sans-serif; | ||
--pure-white: #ffffff; | ||
--primary-color: #b9c6d2; | ||
--secondary-color: #d0dde9; | ||
--tertiary-color: #edf0f8; | ||
--accent-color: #ff3e00; | ||
--heading-color: rgba(0, 0, 0, 0.7); | ||
--text-color: #444444; | ||
--background-without-opacity: rgba(255, 255, 255, 0.7); | ||
} | ||
|
||
[data-theme='dark'] { | ||
--primary-color: #1f272e; | ||
--secondary-color: #2e3a44; | ||
--tertiary-color: #393d45; | ||
--accent-color: #ff3e00; | ||
--heading-color: #ffffff; | ||
--text-color: #ffffff; | ||
--secondary-text-color: #676778; | ||
--background-without-opacity: rgba(255, 255, 255, 0.2); | ||
} | ||
|
||
body { | ||
margin: 0; | ||
min-height: 100vh; | ||
background-color: var(--primary-color); | ||
background: linear-gradient( | ||
180deg, | ||
var(--primary-color) 0%, | ||
var(--secondary-color) 10.45%, | ||
var(--tertiary-color) 41.35% | ||
); | ||
} | ||
|
||
body::before { | ||
content: ''; | ||
width: 80vw; | ||
height: 100vh; | ||
position: absolute; | ||
top: 0; | ||
left: 10vw; | ||
z-index: -1; | ||
background: radial-gradient( | ||
50% 50% at 50% 50%, | ||
var(--pure-white) 0%, | ||
rgba(255, 255, 255, 0) 100% | ||
); | ||
opacity: 0.05; | ||
} | ||
|
||
#svelte { | ||
min-height: 100vh; | ||
display: flex; | ||
flex-direction: column; | ||
} | ||
|
||
h1, | ||
rafaelcamaram marked this conversation as resolved.
Show resolved
Hide resolved
|
||
h2, | ||
p { | ||
font-weight: 400; | ||
text-align: center; | ||
color: var(--heading-color); | ||
} | ||
|
||
h1 { | ||
font-size: 2rem; | ||
margin-bottom: 0; | ||
} | ||
|
||
h2 { | ||
font-size: 1rem; | ||
} | ||
|
||
@media (min-width: 480px) { | ||
h1 { | ||
font-size: 3rem; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would have left that in it's really easy to setup, we don't even need to add much code modifications. Also, do we have any data how many people would choose what? I think people would opt for scss quite a bit just because many component libraries use it for their styling/theming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I see your point.. The only drawback I see is that we would need to maintain 3 different styling files (I believe that's why @benmccann suggested removing it) but i's not a big deal for me -- it'd be easy to revert.
@dummdidumm @benmccann How should I move forward with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We chatted about this part for a bit and it sounds like @Rich-Harris and @pngwn also vote to take out the CSS stuff