Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serve_prerendered breaks on node http server #8890

Merged
merged 5 commits into from
Feb 6, 2023

Conversation

gtm-nayan
Copy link
Contributor

fixes #8888
Tests have been disabled for adapter-node since #2931, so didn't add any in this one. Will look into re-enabling.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@@ -32,6 +32,7 @@
"prepublishOnly": "pnpm build"
},
"devDependencies": {
"@polka/url": "^1.0.0-next.21",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this need to be a regular dependency if we're using it in the code the user gets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because it gets bundled.

@Rich-Harris Rich-Harris merged commit 66ae0a2 into master Feb 6, 2023
@Rich-Harris Rich-Harris deleted the adapter-node-http-url branch February 6, 2023 15:40
@github-actions github-actions bot mentioned this pull request Feb 6, 2023
@Rich-Harris
Copy link
Member

oops! thanks for the fix. re tests — something i've been meaning to get round to for the longest time is:

  • add realistic playwright tests that are part of the project template
  • rig up test apps for each of the adapters that are rebuilt and deployed whenever Kit, the adapter, or the project template changes
  • after each deploy, run the tests against the deployed URL

for adapter-node we could use render or fly or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sveltejs/adapter-node error when used as handler with native node http package
3 participants