Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prettier-plugin-svelte path #8679

Closed
wants to merge 2 commits into from

Conversation

joas8211
Copy link

Fixes #7582 according to prettier/prettier-vscode#1261 (comment)

The issue is you have an invalid value set in “plugins”. It’s not a list of plugins, it’s a file path to the plugin. Set the value to ./directory/plugin and it will work.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023

🦋 Changeset detected

Latest commit: 0919df1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Thank you but I don't think this is right — prettier-plugin-svelte works just fine for me, and specifying ./node_modules/prettier-plugin-svelte risks breaking things in some monorepo setups. The documentation uses the same convention of using conventional module specifiers.

@joas8211
Copy link
Author

@Rich-Harris I did some investigation and it seems it only happens when the Svelte Kit project is not in the VSCode workspace root. When the problem occures VSCode Svelte (not Prettier) extension outputs the following.

Error: Cannot find module 'prettier-plugin-svelte'
Require stack:
- /home/joas/files/projects/web/svelte-kit-test/sub/node_modules/prettier/index.js
- /home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/dist/src/importPackage.js
- /home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/dist/src/lib/documents/configLoader.js
- /home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/dist/src/lib/documents/Document.js
- /home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/dist/src/lib/documents/index.js
- /home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/dist/src/server.js
- /home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/bin/server.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:987:15)
    at resolve (node:internal/modules/cjs/helpers:108:19)
    at /home/joas/files/projects/web/svelte-kit-test/sub/node_modules/prettier/index.js:38104:25
    at Array.map (<anonymous>)
    at Object.load (/home/joas/files/projects/web/svelte-kit-test/sub/node_modules/prettier/index.js:38099:65)
    at Object.load [as loadPlugins] (/home/joas/files/projects/web/svelte-kit-test/sub/node_modules/prettier/index.js:16147:23)
    at /home/joas/files/projects/web/svelte-kit-test/sub/node_modules/prettier/index.js:38166:24
    at Object.format (/home/joas/files/projects/web/svelte-kit-test/sub/node_modules/prettier/index.js:38182:12)
    at SveltePlugin.formatDocument (/home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/dist/src/plugins/svelte/SveltePlugin.js:66:40)
    at async PluginHost.tryExecutePlugin (/home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/dist/src/plugins/PluginHost.js:321:20) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/joas/files/projects/web/svelte-kit-test/sub/node_modules/prettier/index.js',
    '/home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/dist/src/importPackage.js',
    '/home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/dist/src/lib/documents/configLoader.js',
    '/home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/dist/src/lib/documents/Document.js',
    '/home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/dist/src/lib/documents/index.js',
    '/home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/dist/src/server.js',
    '/home/joas/.vscode/extensions/svelte.svelte-vscode-107.0.1/node_modules/svelte-language-server/bin/server.js'
  ]
}

Maybe the correct way to solve this is to fix the extension.

@Rich-Harris
Copy link
Member

cc @dummdidumm!

@Rich-Harris
Copy link
Member

closing in favour of sveltejs/language-tools#1766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"plugins": ["prettier-plugin-svelte"] in .prettierrc is preventing VSCode for auto-formatting *.svelte files
2 participants