Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @rollup/plugin-json to v6 #8204

Merged
merged 3 commits into from
Dec 18, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 17, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@rollup/plugin-json (source) ^5.0.1 -> ^6.0.0 age adoption passing confidence
@rollup/plugin-json (source) ^5.0.2 -> ^6.0.0 age adoption passing confidence

Release Notes

rollup/plugins

v6.0.0

Compare Source

2022-12-17

Breaking Changes
  • fix: log more robustly when JSON parsing fails #​1361

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2022

🦋 Changeset detected

Latest commit: fcf4bf2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dominikg dominikg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to be careful with renovate PRs now, this changes a dependency of adapter-node so needs a changeset.
we also have to check if this could be breaking.

marking as changes needed to avoid accidental merge

@benmccann
Copy link
Member

This change is safe. It's just a change to error handling: https://github.com/rollup/plugins/blob/master/packages/json/CHANGELOG.md#breaking-changes

We do need a changeset

@renovate
Copy link
Contributor Author

renovate bot commented Dec 17, 2022

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@dominikg
Copy link
Member

dominikg commented Dec 17, 2022

they changed this.warn to this.error, which fails the build.

https://github.com/rollup/plugins/pull/1361/files#diff-412d92e18a781647b77d5c02b40f7dd4c377fdc88c77e35013af3957135cc879R27

https://rollupjs.org/guide/en/#thiserror

this is probably desired, nontheless updating can fail a build that previously passed with a warning.

@benmccann
Copy link
Member

Yeah, I'd consider it more of a bug fix than breaking change

@benmccann benmccann merged commit 4e8ff24 into master Dec 18, 2022
@benmccann benmccann deleted the renovate/rollup-plugin-json-6.x branch December 18, 2022 04:17
@github-actions github-actions bot mentioned this pull request Dec 18, 2022
robBowes pushed a commit to robBowes/kit that referenced this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants