-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency @rollup/plugin-json to v6 #8204
Conversation
🦋 Changeset detectedLatest commit: fcf4bf2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have to be careful with renovate PRs now, this changes a dependency of adapter-node so needs a changeset.
we also have to check if this could be breaking.
marking as changes needed to avoid accidental merge
This change is safe. It's just a change to error handling: https://github.com/rollup/plugins/blob/master/packages/json/CHANGELOG.md#breaking-changes We do need a changeset |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. ⚠ Warning: custom changes will be lost. |
they changed this.warn to this.error, which fails the build. https://rollupjs.org/guide/en/#thiserror this is probably desired, nontheless updating can fail a build that previously passed with a warning. |
Yeah, I'd consider it more of a bug fix than breaking change |
Co-authored-by: Dominik G. <[email protected]>
Co-authored-by: Ben McCann <[email protected]> Co-authored-by: Dominik G. <[email protected]>
This PR contains the following updates:
^5.0.1
->^6.0.0
^5.0.2
->^6.0.0
Release Notes
rollup/plugins
v6.0.0
Compare Source
2022-12-17
Breaking Changes
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.