allow .d.ts files to have + prefix #7682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1bec738 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
approved these changes
Nov 16, 2022
dummdidumm
reviewed
Nov 16, 2022
| @@ -192,7 +192,7 @@ function create_routes_and_nodes(cwd, config, fallback) { | |||
| // process files first | |||
| for (const file of files) { | |||
| if (file.is_dir) continue; | |||
| if (!file.name.startsWith('+')) continue; | |||
| if (!file.name.startsWith('+') || file.name.endsWith('.d.ts')) continue; | |||
There was a problem hiding this comment.
mhhhhm or should we scope it to "file ends with .d.ts but has to have one of the known file names"? So that you can't do +yolo.d.ts
There was a problem hiding this comment.
blurgh i guess we probably should
|
Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7662
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0