Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] correctly strip data suffix at root page #7445

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Oct 31, 2022

Fixes #7434
Was accidentally introduced through #7419

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2022

🦋 Changeset detected

Latest commit: 8e82063

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit ebfc050 into master Oct 31, 2022
@dummdidumm dummdidumm deleted the fix-data-suffix branch October 31, 2022 09:14
@dominikg
Copy link
Member

looks good. is it possible to add a regression test to this. feels pretty critical to ensure that invalidation et al is working correctly

@dummdidumm
Copy link
Member Author

yeah it's on my todo-list for later, but first want to get the fix out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not found: /__data.json when use form actions with use:enhance
2 participants