Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update adapters to esbuild 0.15 #6740

Merged
merged 5 commits into from
Sep 12, 2022

Conversation

Conduitry
Copy link
Member

I was wondering why my project's lockfile had gotten so much longer after a recent upgrade, and at least part of the reason is that Vite 3.1.0 is bringing in esbuild 0.15 and the adapters are bringing in 0.14. This updates all of the adapters to ^0.15.6, the same range as Vite currently uses.

While I was at it, I also updated some dev deps on Vite throughout this repo from the 3.1.0 beta to ^3.1.0, so we don't have two versions of Vite getting installed.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2022

🦋 Changeset detected

Latest commit: bbc4e4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-vercel Patch
create-svelte Patch
@sveltejs/adapter-auto Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -13,7 +13,7 @@
"svelte": "^3.48.0",
"svelte-preprocess": "^4.10.6",
"typescript": "^4.8.2",
"vite": "3.1.0-beta.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably add create-svelte to the changelog as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the package.json that's used when people run the CLI. That's package.template.json, which was already updated.

@dummdidumm dummdidumm merged commit b32b3ac into sveltejs:master Sep 12, 2022
@Conduitry Conduitry deleted the esbuild-0.15 branch September 12, 2022 08:16
@Conduitry
Copy link
Member Author

The change to the changeset in bbc4e4e was not correct. This doesn't update any user-visible dependencies to Vite 3.1.0, and doesn't affect what create-svelte creates. I've reverted it in b68f242.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants