-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support https #462
support https #462
Conversation
Do we want this for |
Do we really want to worry about this, or want to encourage people to do SSL in Node? Generally people should be using a separate reverse proxy for this. |
I do see people occasionally request https in dev, and having a built-in https method which generates certificate is a significant boost for them. Trying to do the same with Sapper right now is pretty dificult. There are certain libs which won't work unless you can set up SSL in dev, so I'm in favour of this. For prod, no, we should not be encouraging node SSL or self-signed certificates, so this shouldn't go near the adapters. |
so does it mean, it's better to be in |
I would think if it were only going to be in one then |
I want to support https when starting the server, but not sure how should we specify the config for cert, key, etc.
We could put it into svelte.config.js, but i feel it might be duplicated from vite's https://vitejs.dev/config/#server-https ?