-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow InputProps
and OutputProps
to be typed in generated Load
#4305
allow InputProps
and OutputProps
to be typed in generated Load
#4305
Conversation
🦋 Changeset detectedLatest commit: 2d367e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I also have noticed the same issue with the generated I'm not sure what to do with the |
d609bb1
to
2d367e7
Compare
Thanks! Yeah, it makes sense to expose |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0Same fix as here: #4160
But this time for the generated
Load
type.I also have restricted all the
Params
andProps
types with theextends
keyword.Maybe it makes sense to create a "base type" and use it everywhere: