-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify hash change click handler #3975
Simplify hash change click handler #3975
Conversation
🦋 Changeset detectedLatest commit: af07e78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Good catch, thanks. I fiddled with the logic a bit as it feels like it should be encapsulated within Technically this is a breaking change since someone could reference |
Yeah, no problem, yeah that makes sense, I didn't want to change to much on my own. but that's definitely better. |
@Rich-Harris just one more thing, in normal click navigation, first the URL changes, and then store changes, in this hash case, it's the opposite, we can fix that by calling |
that's true. i think it's probably fine — only issue would be if someone was reading |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0Simplifies hash handling initiated by click. as @benmccann pointed out in #3873 (comment) we don't really need to call renderer.update when the only thing needed update is page store, so that's what we are doing here, this is close to the browser default behavior, and since
@Rich-Harris merged pulls #3931 and #3938 we can now do that.