Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds context to platform in SvelteKit endpoints #3868

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

isaac-mcfadyen
Copy link
Contributor

@isaac-mcfadyen isaac-mcfadyen commented Feb 12, 2022

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Changes

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2022

🦋 Changeset detected

Latest commit: d5bb106

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 12, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: e37cbed

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/62085b698a077000074e4457

@Rich-Harris Rich-Harris merged commit 9ee4934 into sveltejs:master Feb 14, 2022
@Rich-Harris
Copy link
Member

thanks!

This was referenced Feb 14, 2022
@half2me
Copy link
Contributor

half2me commented Feb 23, 2022

Is there a reason why adapter-cloudflare-workers missed out on this? Can we add this there too?

@isaac-mcfadyen
Copy link
Contributor Author

isaac-mcfadyen commented Feb 23, 2022

Is there a reason why adapter-cloudflare-workers missed out on this? Can we add this there too?

From what it looks like here, adapter-cloudflare-workers doesn't use platform at all (so no env or context):

return await server.respond(request);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose cloudflare specific functionality (event.waitUntil) in hooks
4 participants