-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
give module id an invalid name to prevent invalid replacement #3546
Conversation
🦋 Changeset detectedLatest commit: 4a4d866 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 4a4d866 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61f183970bf8870008bfd00f |
packages/adapter-netlify/index.js
Outdated
@@ -51,7 +51,7 @@ export default function ({ split = false } = {}) { | |||
const redirects = []; | |||
|
|||
const replace = { | |||
APP: './server/app.js' | |||
'0APP': './server/app.js' // digit prefix prevents CJS build from using this as a variable name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i might add a bit more detail
'0APP': './server/app.js' // digit prefix prevents CJS build from using this as a variable name | |
'0APP': './server/app.js' // digit prefix prevents CJS build from using this as a variable name to ensure replace doesn't replace occurrences of variables with this string |
fixes #3526. #3528 was close, but still had the bug — in order to fix it we need the module ID to be something that Rollup can't (in its desire to generate readable code) turn into an identical variable name. We can't use something like
{APP}
because that seems to cause issues with string replacement (possibly word boundary related? couldn't quite be bothered to figure it out), but if we prefix the ID with a number than Rollup is forced to add another character, thus hacking around the issue.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0