-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip navigation if only url hash change #3177
Conversation
🦋 Changeset detectedLatest commit: ed91ca8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: ed91ca8 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d2e1b61fee1200089d0173 |
await page.click('[href="#hash-target"]'); | ||
await clicknav('[href="/routing/hashes/b"]'); | ||
|
||
await back(); | ||
await page.goBack(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this to page.click
and page.goBack
since the clicknav
and back
utils rely on sveltekit:navigation-end
to resolve, which these hash-only anchor tags would skip, resulting in timeout.
Using playwright's builtin functions to avoid it.
); | ||
}, | ||
// Does not work in nojs | ||
{ nojs: false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In no-js, the default page focus after Tab
is the document body, which fails this test. I'm not entirely clear why it works in js, but I'm skipping this for now.
Fixes #3105
Fixes #2667
If only the URL hash change when navigating via anchor tags, e.g.
<a href="#foo">
, skip router navigation and let the default browser behaviour to kick in.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0