[fix] fallback should still be generated when prerender is disabled #2128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1588
The bug described in #1588 is about the adapter-static in SPA-mode (-> fallback set) not outputting the {fallback}.html file into the build directory when config.kit.prerender.enabled is set to
false
.This PR is an easy fix for this behavior, as config.kit.prerender.enabled can be ignored in the SPA mode. It bypasses the check for
config.kit.prerender.enabled
in the getter for the prerender function by modifying the expression to be true by default when a fallback is defined.You can see that this fixes the bug on the branch
bug-demonstration
on my fork of sveltejs/kit.For this,
git clone https://github.com/Theo-Steiner/kit.git
checkout bug-demonstration
,pnpm i
,pnpm build
cd examples/kit-bug
pnpm build
and dols build
and you will see that index.html was in fact created!I did not include a test, since I honestly don't know how I would test for this behavior.
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0