Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] fulfil rawBody data once #1894

Merged
merged 1 commit into from
Jul 13, 2021
Merged

[fix] fulfil rawBody data once #1894

merged 1 commit into from
Jul 13, 2021

Conversation

ignatiusmb
Copy link
Member

Previous early return were to stop further fulfilments, the intent should be clearer by using else block here.

Related #1890, #1528

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7367c57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann merged commit 3bafe56 into sveltejs:master Jul 13, 2021
@benmccann
Copy link
Member

oops. I missed that the first one didn't have a return. thanks for catching that!

@ignatiusmb ignatiusmb deleted the fix/prevent-continued-decoding branch July 13, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignatiusmb @benmccann