Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silence dev/prod warning during sync #13244

Merged
merged 1 commit into from
Dec 27, 2024
Merged

fix: silence dev/prod warning during sync #13244

merged 1 commit into from
Dec 27, 2024

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Dec 26, 2024

closes #13238

this avoids loading the dev check so it doesn't care if we tell it we're in dev or prod mode

Copy link

changeset-bot bot commented Dec 26, 2024

🦋 Changeset detected

Latest commit: fe26176

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13244-svelte.vercel.app/

this is an automated message

Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eltigerchino eltigerchino merged commit 528af75 into main Dec 27, 2024
14 checks passed
@eltigerchino eltigerchino deleted the browser-only branch December 27, 2024 01:56
This was referenced Dec 26, 2024
@Gerschtli
Copy link

This issue still exists with v2.15.1 which contains this fix.

@eltigerchino
Copy link
Member

This issue still exists with v2.15.1 which contains this fix.

Please open a new issue with a minimal reproduction

@benmccann
Copy link
Member Author

Agreed. The issue is fixed in the project provided here. You must have a different issue

@Gerschtli
Copy link

Good to know, I will have another look, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte-kit sync outputs "If bundling, conditions should include development or production...."
4 participants