-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly handle pathnames found in the _redirects
file
#12821
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: b22a60d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I see this method is building a |
preview: https://svelte-dev-git-preview-kit-12821-svelte.vercel.app/ this is an automated message |
Thanks, that's a good suggestion. I've added a link to the _routes.json documentation. |
packages/adapter-cloudflare/index.js
Outdated
@@ -217,6 +221,21 @@ function get_routes_json(builder, assets, { include = ['/*'], exclude = ['<all>' | |||
return builder.prerendered.paths; | |||
} | |||
|
|||
if (rule === '<redirects>' && existsSync(redirects_file)) { | |||
const redirects = readFileSync(redirects_file, 'utf8') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might be able to put everything after reading the file into a method like parse_redirects
that has a unit test. I get a bit nervous that the adapters keep growing without having any tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a test but I'm not sure if it's enough. Should I add another one to test the case where the redirects parsing fails?
closes #9138
We need to add the pathnames found in the Cloudflare
_redirects
file to theexclude
array so that they are handled by Cloudflare Pages rather than the Cloudflare Pages worker. This PR also adds the<redirects>
directive so that it can be included manually in theexclude
array in_routes.json
.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits