fix: emulate event.platform during development even if route is undefined
#12513
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ec990b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yutak23
changed the title
event.platform even if route is undefined
eltigerchino
added
pkg:adapter-cloudflare-workers
pkg:adapter-cloudflare
adapters - general
Co-authored-by: Tee Ming <[email protected]>
yutak23
changed the title
event.platform even if route is undefinedevent.platform during development even if route is undefined
Comment on lines
300
to
302
| if (!event.platform && DEV && state.emulator?.platform) { | ||
| event.platform = await state.emulator.platform({ config: {}, prerender: false }); | ||
| } |
There was a problem hiding this comment.
@benmccann is this what you meant in #11996 (comment) ? I suppose one more check we need to add is if we're currently rendering a fallback
|
Hi!, should this get merged? I manually change Kit's node_modules file, and this change really made it to work |
eltigerchino
reviewed
Sep 4, 2024
eltigerchino
reviewed
Sep 4, 2024
Co-authored-by: Tee Ming <[email protected]>
Co-authored-by: Tee Ming <[email protected]>
eltigerchino
reviewed
Sep 5, 2024
eltigerchino
approved these changes
Sep 5, 2024
|
Thank you! Sorry this took so long to merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ought to fix #11996
Only if
DEV, config is an empty object and prerender is set tofalseso thatevent.platformcan be emulated.I believe this will improve the development experience by preventing 500 errors and allowing development to occur in a more local development environment similar to the production environment.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits