Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: remove build step for adapter node" #10314

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

gtm-nayan
Copy link
Contributor

Reverts #10041 which broke builds because of rollup/rollup#4708

@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2023

🦋 Changeset detected

Latest commit: 2e01268

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

Do we know what version of undici this is going to leave users with for now? My main concern with reverting this is putting people back on a version with known memory leak issues.

@gtm-nayan
Copy link
Contributor Author

Only version of undici in the lockfile is 5.22.0, memory leak was supposed to have been fixed in 5.21.1

@dummdidumm dummdidumm merged commit 0eefdbb into master Jul 4, 2023
@dummdidumm dummdidumm deleted the revert-10041-adapter-node-externalize branch July 4, 2023 08:38
@github-actions github-actions bot mentioned this pull request Jul 4, 2023
@charbelnicolas
Copy link

This was driving me crazy yesterday! I'm glad it got fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants