Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional parameters chain - 404 error #9261

Closed
verso-O opened this issue Mar 1, 2023 · 0 comments · Fixed by #9266
Closed

Optional parameters chain - 404 error #9261

verso-O opened this issue Mar 1, 2023 · 0 comments · Fixed by #9266
Labels
bug Something isn't working ready to implement please submit PRs for these issues!
Milestone
soon

Comments

@verso-O
Copy link

verso-O commented Mar 1, 2023

Describe the bug

Considering the following route path:

/[[param1=param1]]/[[param2=param2]]/constant/[[param3=param3]]/

  • /a/b/constant/c succeed.
  • /a/constant/c succeed.
  • /b/constant/c fails with 404 (not matched by the router).

Reproduction

https://stackblitz.com/edit/sveltejs-kit-template-default-wemn13

Logs

No response

System Info

System:
    OS: macOS 13.2.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 1.99 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.17.0 - /usr/local/bin/node
    Yarn: 3.3.0 - /usr/local/bin/yarn
    npm: 8.19.3 - /usr/local/bin/npm
  Browsers:
    Chrome: 110.0.5481.177
    Firefox: 109.0
    Safari: 16.3

Severity

blocking an upgrade

Additional Information

No response
@dummdidumm dummdidumm added bug Something isn't working ready to implement please submit PRs for these issues! labels Mar 1, 2023
@dummdidumm dummdidumm added this to the soon milestone Mar 1, 2023
@glennsayers glennsayers mentioned this issue Mar 1, 2023
Merged
5 tasks
Rich-Harris pushed a commit that referenced this issue Mar 2, 2023
@glennsayers @benmccann
fix: successive optional route parameters can now be empty (#9266)
1e2c826 
* Optional chained parameters can be skipped - close #9261

* Update changeset description

Co-authored-by: Ben McCann <[email protected]>

---------

Co-authored-by: Ben McCann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ready to implement please submit PRs for these issues!
Projects
None yet
Milestone
soon
Development

Successfully merging a pull request may close this issue.

fix: successive optional route parameters can now be empty
2 participants
@dummdidumm @verso-O