Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change arguments for @rollup/plugin-commonjs #8891

Closed
AlexRMU opened this issue Feb 5, 2023 · 0 comments · Fixed by #8958
Closed

Change arguments for @rollup/plugin-commonjs #8891

AlexRMU opened this issue Feb 5, 2023 · 0 comments · Fixed by #8958

Comments

@AlexRMU
Copy link

AlexRMU commented Feb 5, 2023

Describe the problem

Due to the current arguments, some errors may appear:
Automattic/mongoose#12335
rollup/rollup#4787
solidjs/solid-start#626

Describe the proposed solution

Example:

plugins: [nodeResolve({ preferBuiltins: true }), commonjs(), json()],

-plugins: [nodeResolve({ preferBuiltins: true }), commonjs(), json()],
+plugins: [nodeResolve({ preferBuiltins: true }), commonjs({ strictRequires: true }), json()],

Alternatives considered

No response

Importance

would make my life easier

Additional Information

https://github.com/rollup/plugins/tree/master/packages/commonjs#strictrequires

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants