Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo App: Todo doesn't work without Javascript #3952

Closed
decherd opened this issue Feb 16, 2022 · 1 comment
Closed

Demo App: Todo doesn't work without Javascript #3952

decherd opened this issue Feb 16, 2022 · 1 comment

Comments

@decherd
Copy link

decherd commented Feb 16, 2022

Describe the bug

The Demo App Todo page does not work without Javascript and returns a 500 status code along with this error: Body returned from shadow endpoint request handler must be a plain object.

Reproduction

I don't think I need to link back to this repo. Again, it is just the demo app.

Logs

Body returned from shadow endpoint request handler must be a plain object
Error: Body returned from shadow endpoint request handler must be a plain object
    at validate_shadow_output (file:///Users/drew/Projects/demo_app2/.svelte-kit/runtime/server/index.js:1999:9)
    at load_shadow_data (file:///Users/drew/Projects/demo_app2/.svelte-kit/runtime/server/index.js:1910:38)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async load_node (file:///Users/drew/Projects/demo_app2/.svelte-kit/runtime/server/index.js:1565:5)
    at async respond$1 (file:///Users/drew/Projects/demo_app2/.svelte-kit/runtime/server/index.js:2194:15)
    at async render_page (file:///Users/drew/Projects/demo_app2/.svelte-kit/runtime/server/index.js:2395:19)
    at async resolve (file:///Users/drew/Projects/demo_app2/.svelte-kit/runtime/server/index.js:2660:11)
    at async Object.handle (/Users/drew/Projects/demo_app2/src/hooks.ts:9:24)
    at async respond (file:///Users/drew/Projects/demo_app2/.svelte-kit/runtime/server/index.js:2567:20)
    at async file:///Users/drew/Projects/demo_app2/node_modules/@sveltejs/kit/dist/chunks/index.js:244:24

System Info

System:
    OS: macOS 12.1
    CPU: (4) x64 Intel(R) Core(TM) i5-6360U CPU @ 2.00GHz
    Memory: 157.93 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.0 - /usr/local/bin/node
    Yarn: 1.10.1 - /usr/local/bin/yarn
    npm: 8.3.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 98.0.4758.80
    Firefox: 66.0.4
    Safari: 15.2
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.17
    @sveltejs/kit: next => 1.0.0-next.272
    svelte: ^3.46.0 => 3.46.4

Severity

annoyance

Additional Information

No response

Rich-Harris added a commit that referenced this issue Feb 17, 2022
* [fix] make demo app work without JS

* alternative approach to #3965

* actually

Co-authored-by: Geoff Rich <[email protected]>
@benmccann
Copy link
Member

I believe this was fixed by #3970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants