-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests are not running #2069
Comments
There seems to be a large number of tests being skipped. This appears to be the last build of master where most tests were not skipped: And this looks like the first master build where many tests are skipped, and is still occurring: |
Test 'successfully' fails again when reverting packages/kit/tset/apps/basics/package.json back to the original code here: If I submit a pull request, should I attempt fixing the other tests? |
actually I can see |
I just changed it locally back to:
It doesn't look like it changes anything. I changed a test so that it should fail and I'm still not seeing any test failures The reason for changing was so that I could run the test projects myself with
I think the path is correct as is since the following works:
|
Aha!! Thank you! That helped me figure it out: e8b391b |
".only()" 😆 |
now we see, there is tons of errors... yikes |
yeah 😝 that was before I found but yeah, now time to fix all the errors 😢 |
I also have idea, we should probably set in workflow, that skipped tests must be = 0. |
So test were not running from Jul 13, 2021... Yikes,... how a lot of code changes in half month? |
It would be a good idea to use eslint-plugin-jest and enforce the linting in the CI. The plugin does not allow skipping or restricting tests. |
Describe the bug
It looks like our browser tests are not running
This would explain recent regressions (e.g. #2041)
I'm hesitant to merge any PRs until this gets fixed. I've added a note to the PR template informing PR submitters of this
Help looking into this issue would be appreciated
Reproduction
If I make the first line
throw new Error('this should fail');
the test suite still passeskit/packages/kit/test/apps/basics/src/routes/routing/_tests.js
Line 205 in 459efa2
Logs
No response
System Info
`master`
Severity
blocking an upgrade
Additional Information
No response
The text was updated successfully, but these errors were encountered: