-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallthrough routes (2 routes with slugs on same level) Regression issue .137 #2041
Comments
Relevant discord discussion: https://discord.com/channels/457912077277855764/819723698415599626/870554215091683339 From Rainlife's comment it looks like this worked in .136 and broke with .137 |
all my |
Hmm. 137 enabled strict TypeScript checking: https://github.com/sveltejs/kit/blob/master/packages/kit/CHANGELOG.md#100-next137 It's a pretty big diff, so not easy to narrow down from the diff what might have changed Can either of you provide a repository that reproduces this? |
Hi @benmccann, Here is a reproduction repo that contains two issues I've noticed: https://github.com/JulienPradet/sveltekit-2041
I couldn't reproduce @UltraCakeBakery's issue though but I guess it's close to the endpoint issue. |
We have tests for fallthrough, but it turns out they're not running 🤷 #2069 |
Tests are now running and failing. Now they need to be fixed |
@benmccann Not sure if this is helpful, but the more complicated test seems to have broken in the commit below: The specific file linked is part of what you changed in #2072 Your efforts are appreciated! |
Describe the bug
I cannot make a route fallthough when in SSR, this works as expected when client is navigating
This also affects when I export with static-adapter as all these routes return 500
Reproduction
This issue only appears in SSR mode, I reproduce by going to the route in question and refreshing (F5)
I have 2 routes:
src/routes/[legal]/index.svelte
src/routes/[page]/index.svelte
I manually check in my load function inside src/routes/[legal]/index.svelte
if (!validRoute) return
But this never reaches the load function in src/routes/[page]/index.svelte I see a 500 Internal server error in my console and the page shows the following message:
Bad request in load function: “failed to fetch undefined”
Logs
No response
System Info
Severity
blocking an upgrade
Additional Information
No response
The text was updated successfully, but these errors were encountered: