Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add create-svelte package #2

Closed
Rich-Harris opened this issue Oct 15, 2020 · 2 comments
Closed

add create-svelte package #2

Rich-Harris opened this issue Oct 15, 2020 · 2 comments

Comments

@Rich-Harris
Copy link
Member

i'm now the owner of https://www.npmjs.com/package/create-svelte
@Conduitry
Copy link
Member

Oh nice, that was fast.

@Rich-Harris
Copy link
Member Author

Created a placeholder: https://github.com/sveltejs/kit-mono/tree/master/packages/create-svelte. Am publishing with pnpm publish --tag next.

At some point we'll need to figure out how to make it so that the same people who can publish to @sveltejs packages can publish this. At the moment I'm the only owner

@Nick-Mazuk Nick-Mazuk mentioned this issue Apr 1, 2021
Closed
@ClaytonFarr ClaytonFarr mentioned this issue May 23, 2021
Closed
@endigo9740 endigo9740 mentioned this issue Nov 24, 2021
Closed
zommerberg referenced this issue in zommerberg/kit Dec 8, 2021
@zommerberg
docs fixes #2
73f8d2b
zommerberg referenced this issue in zommerberg/kit Dec 8, 2021
@zommerberg
docs fixes #2
32f305e
zommerberg referenced this issue in zommerberg/kit Dec 12, 2021
@zommerberg
snake case #2
6055ae7
Rich-Harris added a commit that referenced this issue Jan 13, 2022
@Rich-Harris @zommerberg
@benmccann @bluwy @PatrickG @ignatiusmb
[feat] beforeNavigate and afterNavigate lifecycle functions (#3293)
cb44e28 
* feature/add-onBeforeNavigate-listner

* minor fixes

* naming

* minor naming changs

* minor improvements

* implement requested changes

* add newline

* newline fix

* docs fixes

* docs fixes #2

* docs fixes #2

* docs spacing

* minor docs fix

* speeling fix

* remove if(browser) check

* types

* snake_case

* snake case #2

* naming

* Update documentation/docs/05-modules.md

Co-authored-by: Ben McCann <[email protected]>

* Update pnpm-lock.yaml

* add onNavigate method

* Update packages/kit/src/runtime/client/router.js

Co-authored-by: Bjorn Lu <[email protected]>

* Update packages/kit/test/test.js

Co-authored-by: Bjorn Lu <[email protected]>

* minor naming and types improvements

* add docs

* mroe docs fixes

* snake case

* improve back/forwar browser handling

* improve sveltekit:index

* remove custom event, add callbacks.

* typo fix

* docs

* remove logs

* namig

* Update packages/kit/src/runtime/client/router.js

Co-authored-by: Bjorn Lu <[email protected]>

* fixes

* improve types

* nicer format

* Added second parameter to `goto` function in tests

* Fixed `history.state` when fixing trailing slash

* Added tests for `onBeforeNavigate`

* lints

* add more tests

* reafactor

* fix if statement

* fix if statement 2

* remove unused files

* fix test

* patch changeset

* rename to beforeNavigate/afterNavigate

* typo

* make beforeNavigate callbacks synchronous

* rename internal functions

* make _navigate take non-position arguments. bit clearer

* remove sveltekit:index tests - this is non-user-facing implementation detail

* typo

* remove more sveltekit:index stuff

* separate out beforeNavigate tests

* simplify tests

* rename tests

* handle no-router case

* simplify some stuff

* only pass scroll/keepfocus to renderer

* focus beforeNavigate tests

* manage history index inside _navigate

* neaten up

* allow _navigate to handle external links; centralise logic

* pass { from, to, cancel } to beforeNavigate callbacks

* lint

* block unload if appropriate

* make goto work with external urls

* unfocus tests

* typechecking

* no longer needs to be async

* update docs

* call afterNavigate callbacks on page load

* typechecking

* Update documentation/docs/05-modules.md

Co-authored-by: Ben McCann <[email protected]>

Co-authored-by: pavelBelyaev98 <[email protected]>
Co-authored-by: Pavel Belyaev <[email protected]>
Co-authored-by: Ben McCann <[email protected]>
Co-authored-by: Bjorn Lu <[email protected]>
Co-authored-by: Patrick <[email protected]>
Co-authored-by: Ignatius Bagus <[email protected]>
Theo-Steiner added a commit to Theo-Steiner/kit that referenced this issue Jan 24, 2022
@Theo-Steiner
Revert "Revert change of cloning response as bug was actually in prer…
efd3fec 
…ender.js"

This reverts commit 5e5f30b.

Revert being stupid sveltejs#2
Rich-Harris added a commit that referenced this issue Jan 26, 2022
@Theo-Steiner @Rich-Harris
[fix] reading from same response body twice during prerender (#3473) (#…
2dc7774 
…3521)

* Add failing test for #3473 prerender error body used already

* Fix reading from same response body twice during prerender

* Fix quotes

* Add changeset

* Fix casing for internal variables

* Revert change of cloning response as bug was actually in prerender.js

* Avoid reading response body twice

* Revert "Avoid reading response body twice"

This reverts commit cecf7dd.

Revert being stupid #1

* Revert "Revert change of cloning response as bug was actually in prerender.js"

This reverts commit 5e5f30b.

Revert being stupid #2

* store buffered depenedency bodies for prerendering

* failing test for non-buffered endpoint data

* use buffered body if available, otherwise buffer

Co-authored-by: Rich Harris <[email protected]>
@ryanrussell ryanrussell mentioned this issue Apr 26, 2022
Closed
@coryvirok coryvirok mentioned this issue May 7, 2022
Closed
@moisesbites moisesbites mentioned this issue Aug 17, 2022
Closed
@jasongitmail jasongitmail mentioned this issue Jun 13, 2023
Open
@Lms24 Lms24 mentioned this issue Sep 7, 2023
Open
@samijaber samijaber mentioned this issue Dec 7, 2023
Open
@HummingMind HummingMind mentioned this issue Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rich-Harris @Conduitry