Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail with latest version of Svelte #1306

Closed
benmccann opened this issue May 2, 2021 · 2 comments · Fixed by #1337
Closed

Tests fail with latest version of Svelte #1306

benmccann opened this issue May 2, 2021 · 2 comments · Fixed by #1337
Milestone
1.0

Comments

@benmccann
Copy link
Member

I noticed in #1293 that one of the tests was failing. I tracked it down to being due to the Svelte upgrade
@benmccann benmccann added this to the 1.0 milestone May 2, 2021
@benmccann benmccann mentioned this issue May 2, 2021
Merged
@Conduitry
Copy link
Member

Presumably/hopefully this is because of more hydration regressions in 3.38. There are another couple issues on the Svelte repo about that.

@benmccann
Copy link
Member Author

I just see one, but yeah, unfortunately it looks like it may not be completely working yet: sveltejs/svelte#6279

Rich-Harris added a commit that referenced this issue May 4, 2021
@Rich-Harris
update all dependencies. fixes #1306
841e336
@Rich-Harris Rich-Harris mentioned this issue May 4, 2021
Merged
5 tasks
Rich-Harris pushed a commit that referenced this issue May 5, 2021
Update deps (#1337)
f57bf92 
* update all dependencies. fixes #1306

* fix workspace: versions

* Update package.json

* yawn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Update deps sveltejs/kit
2 participants
@benmccann @Conduitry