Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include .gitignore in blank template #1159

Closed
veritem opened this issue Apr 21, 2021 · 3 comments · Fixed by #1167
Closed

Include .gitignore in blank template #1159

veritem opened this issue Apr 21, 2021 · 3 comments · Fixed by #1167
Labels
bug Something isn't working
Milestone
1.0

Comments

@veritem
Copy link
Contributor

veritem commented Apr 21, 2021

When starting out a new project using blank template it's really frustrations that the current version of cli doesn't come with a
.gitingore file which is really helpfully
@veritem veritem changed the title Include gitignore in blank template Include .gitignore in blank template Apr 21, 2021
@Conduitry
Copy link
Member

This is the same as #1036 which was supposed to have been fixed in #1084. But I am still seeing this file missing on the latest version of create-svelte.

@Conduitry Conduitry added the bug Something isn't working label Apr 21, 2021
@Conduitry Conduitry added this to the 1.0 milestone Apr 21, 2021
@Rich-Harris
Copy link
Member

this is weird as hell — it seems to be writing the file, but renaming it to .npmignore. i have no idea how this could be happening

@Rich-Harris
Copy link
Member

ugh. apparently this is something that npm does when it packages things up, instead of, y'know, just interpreting the .gitignore as an .npmignore. how helpful.

Rich-Harris added a commit that referenced this issue Apr 22, 2021
@Rich-Harris
account for the extremely helpful and intuitive npm behaviour - fixes #…
f249c0c 
…1159
@Rich-Harris Rich-Harris mentioned this issue Apr 22, 2021
Merged
5 tasks
Rich-Harris pushed a commit that referenced this issue Apr 22, 2021
account for the extremely helpful and intuitive npm behaviour - fixes #…
2bf4338 
…1159 (#1167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

account for the extremely helpful and intuitive npm behaviour sveltejs/kit
3 participants
@Rich-Harris @Conduitry @veritem