fix: use esbuildOptions parameter

sveltejs · Jun 16, 2021 · dfae928 · dfae928
1 parent ed6b445
commit dfae928
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 22 deletions.
diff --git a/packages/adapter-node/README.md b/packages/adapter-node/README.md
@@ -14,23 +14,42 @@ export default {
 	kit: {
 		adapter: adapter({
 			// default options are shown below
-			outdir: 'build',
-			outfile: join(outdir, 'index.js')
-			bundle: true,
-			format: 'esm',
-			platform: 'node',
-			target: 'node12',
-			external: Object.keys(JSON.parse(readFileSync('package.json', 'utf8')).dependencies || {}),
+			out: 'build',
+			esbuildOptions: {
+				outdir: out,
+				bundle: true,
+				format: 'esm',
+				platform: 'node',
+				target: 'node12',
+				external: [
+					/* package.json#dependencies */
+				]
+			}
 		})
 	}
 };
 ```
 
 ## Options
 
-All [esbuild build](https://esbuild.github.io/api/#build-api) options except for `entryPoints` are supported.
+### out
 
-The [outdir](https://esbuild.github.io/api/#outdir) is the directory to build the server to. It defaults to `build` — i.e. `node build` would start the server locally after it has been created.
+The directory to build the server to. It defaults to `build` — i.e. `node build` would start the server locally after it has been created.
+
+### esbuildOptions
+
+Any custom [esbuild build](https://esbuild.github.io/api/#build-api) options. It defaults to:
+
+```js
+{
+	outdir: out /* = 'build' */, // Unless a outfile is specified
+	bundle: true,
+	format: 'esm',
+	platform: 'node',
+	target: 'node12',
+	external: [ /* package.json#dependencies */ ]
+}
+```
 
 ## Environment variables
 

diff --git a/packages/adapter-node/index.d.ts b/packages/adapter-node/index.d.ts
@@ -1,3 +1,6 @@
-declare function plugin(options?: import('esbuild').BuildOptions): import('@sveltejs/kit').Adapter;
+declare function plugin(options?: {
+	out?: string;
+	esbuildOptions?: import('esbuild').BuildOptions;
+}): import('@sveltejs/kit').Adapter;
 
 export = plugin;
diff --git a/packages/adapter-node/index.js b/packages/adapter-node/index.js
@@ -4,25 +4,32 @@ import { fileURLToPath } from 'url';
 import esbuild from 'esbuild';
 
 /**
- * @param {import('esbuild').BuildOptions} options
+ * @param {{
+ *   out?: string,
+ *   esbuildOptions?: import('esbuild').BuildOptions
+ * }} options
  */
 export default function ({
-	outdir = 'build',
-	outfile = join(outdir, 'index.js'),
-	bundle = true,
-	format = 'esm',
-	platform = 'node',
-	target = 'node12',
-	external = Object.keys(JSON.parse(readFileSync('package.json', 'utf8')).dependencies || {}),
-	...esbuildOptions
+	out = 'build',
+	esbuildOptions: {
+		outfile,
+		outdir = typeof outfile === 'undefined' ? out : undefined,
+		bundle = true,
+		format = 'esm',
+		platform = 'node',
+		target = 'node12',
+		external = Object.keys(JSON.parse(readFileSync('package.json', 'utf8')).dependencies || {}),
+		entryPoints = ['.svelte-kit/node/index.js'],
+		...esbuildOptions
+	} = {}
 } = {}) {
 	/** @type {import('@sveltejs/kit').Adapter} */
 	const adapter = {
 		name: '@sveltejs/adapter-node',
 
 		async adapt({ utils }) {
 			utils.log.minor('Copying assets');
-			const static_directory = join(outdir, 'assets');
+			const static_directory = join(out, 'assets');
 			utils.copy_client_files(static_directory);
 			utils.copy_static_files(static_directory);
 
@@ -38,12 +45,12 @@ export default function ({
 				platform,
 				target,
 				external,
-				entryPoints: ['.svelte-kit/node/index.js']
+				entryPoints
 			});
 
 			utils.log.minor('Prerendering static pages');
 			await utils.prerender({
-				dest: `${outdir}/prerendered`
+				dest: `${out}/prerendered`
 			});
 		}
 	};