[fix] dont hardcode version in client bundle (#7694)

fixes #7144
sveltejs · Nov 17, 2022 · d3a5db3 · d3a5db3
1 parent 172e792
commit d3a5db3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/calm-ways-jump.md b/.changeset/calm-ways-jump.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+Don't hardcode version in client bundle
diff --git a/packages/kit/src/exports/vite/build/utils.js b/packages/kit/src/exports/vite/build/utils.js
@@ -147,7 +147,6 @@ export function get_default_build_config({ config, input, ssr, outDir }) {
 		},
 		define: {
 			__SVELTEKIT_ADAPTER_NAME__: JSON.stringify(config.kit.adapter?.name),
-			__SVELTEKIT_APP_VERSION__: JSON.stringify(config.kit.version.name),
 			__SVELTEKIT_APP_VERSION_FILE__: JSON.stringify(`${config.kit.appDir}/version.json`),
 			__SVELTEKIT_APP_VERSION_POLL_INTERVAL__: JSON.stringify(config.kit.version.pollInterval),
 			__SVELTEKIT_BROWSER__: ssr ? 'false' : 'true',

diff --git a/packages/kit/src/runtime/client/utils.js b/packages/kit/src/runtime/client/utils.js
@@ -1,7 +1,8 @@
 import { writable } from 'svelte/store';
 import { assets } from '../paths.js';
+import { version } from '../env.js';
 
-/* global __SVELTEKIT_APP_VERSION__, __SVELTEKIT_APP_VERSION_FILE__, __SVELTEKIT_APP_VERSION_POLL_INTERVAL__ */
+/* global __SVELTEKIT_APP_VERSION_FILE__, __SVELTEKIT_APP_VERSION_POLL_INTERVAL__ */
 
 /** @param {HTMLDocument} doc */
 export function get_base_uri(doc) {
@@ -143,8 +144,8 @@ export function create_updated_store() {
 		});
 
 		if (res.ok) {
-			const { version } = await res.json();
-			const updated = version !== __SVELTEKIT_APP_VERSION__;
+			const data = await res.json();
+			const updated = data.version !== version;
 
 			if (updated) {
 				set(true);