feat: Added the experimental-require-strict-events rule
#365
Conversation
🦋 Changeset detectedLatest commit: 99477b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
…equire-strict-events
…e 111556Events interface
|
Hi @ota-meshi, there are some lint issues but I think they're unrelated to the PR... |
I think merging or rebasing the current main branch will probably solve it. Could you try it? |
No luck :( |
| } | ||
| }, | ||
| "Program:exit"() { | ||
| if (isTs && !hasAttribute && !hasInterface) { |
There was a problem hiding this comment.
Do you think the strictEvents attribute should be given even if createEventDispatcher or on:click are not used?
There was a problem hiding this comment.
Yes, I do - the strictEvents attributes makes all "callers" of the component (i.e. components that contain it) have their on:something handlers checked as well - so even if a component has no events, the strictEvents attribute brings a benefit in that the callers will error if they try to add a handler to a non-existent event.
|
Great, I'll get #368 ready :) |
Closes #345