Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: color help screen #206

Closed
wants to merge 2 commits into from
Closed

chore: color help screen #206

wants to merge 2 commits into from

Conversation

manuel3108
Copy link
Member

Closes #195

Adds some basic color support. Colors can now easily be changed.
The problem is that this currently not supported by commanderm but a PR is on it's way: tj/commander.js#2251
In the meantime it was necessary to pull in a small amount of code from commander to make this work. We might need to debate if it's worth it to pull in that code or to wait.

From a readability pov, i do think this is a major improvement.

image

image

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 08cc0e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@manuel3108 manuel3108 mentioned this pull request Oct 22, 2024
Copy link

pkg-pr-new bot commented Oct 22, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@206

commit: 08cc0e4

@manuel3108
Copy link
Member Author

Does not seem to be as simple as expected and adds a lot of overhead. We will need for the mentioned PR to be implemented to make this work in a better way.

@manuel3108 manuel3108 closed this Nov 5, 2024
@manuel3108 manuel3108 deleted the chore/color-help-screen branch November 5, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding some color
1 participant