feat: Add zod schemas for CI validation #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sveltesociety-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@MacFJA would you be able to have a look at this? |
MacFJA
reviewed
Nov 6, 2023
|
@MacFJA I've applied these changes! |
|
Hi @MacFJA and @benmccann, would either of you be able to review this? Thanks! |
MacFJA
approved these changes
Nov 8, 2023
|
Hey @MacFJA , thanks for reviewing this! I was wondering if there's anything else I need to do before we can merge it? I appreciate your help! |
|
@MacFJA sorry to tag you again, just checking if this was ready to merge? I have another PR lined up that depends on this :) |
Don't worry. As no-one have voiced anything against this PR, I will merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the main feature of #427, which is Zod validation of the JSON files during linting.
Note that the
npmfield is currently optional; this is becausesvelte-layout-resizableandSvelteStoreare missing this field. This can be corrected in a subsequent PR.