feat: ability to use manual script injection in hooks #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: feef749 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fnimick
changed the title
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
- adds a new function to generate the script source for manual injection using a hook - adds a new prop `disableHeadScriptInjection` to disable script addition from the rendered component
fnimick
force-pushed
the
update-head-script-injection
branch
from
ef36566 to
576551a
Compare
|
is there anything I should do to have this considered? |
|
Hey there @fnimick, thanks for this! I need to investigate why the contents of the |
|
Any updates or anything I can do to move this along? |
huntabyte
approved these changes
Nov 19, 2024
huntabyte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new function to return the script source, for manual injection into a
<script>tag using a hook, as described in sveltejs/kit#10377 (comment)Adds a new prop to disable head script addition at the component level, if you are using the above function for manual injection.
Also updates
setInitialModeto correctly use configured local storage keys.