Fix MOAB canonical ordering during element splitting #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we have a test for this somehow? |
|
I'm not sure how we'd test canonical ordering of tetrahedra/splitting of elements directly but one test that we should probably add is to ensure no elements with negative volume are present |
gonuke
reviewed
Oct 21, 2024
| source_mesh.create_mesh() | ||
|
|
||
| assert len(source_mesh.volumes) == num_elements_exp | ||
| assert len([i for i in source_mesh.volumes if i < 0]) == num_neg_vols_exp |
There was a problem hiding this comment.
Nice - does this fail with the old/wrong canonical ordering?
There was a problem hiding this comment.
With the old canonical ordering, this doesn't fail on the test equilibrium, but it does fail with WISTELL-D. On WISTELL-D using these parameters, the number of elements is as expected but 108 elements (1.47%) have negative volume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects implementation of MOAB canonical ordering. Changes are as follows:
Closes #166